bubble up more detailed git errors #427
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divolgin
previously approved these changes
Oct 10, 2024
divolgin
reviewed
Oct 10, 2024
|
|
||
| rev, branch, isDirty, err := r.gitSHABranch() | ||
| if err != nil { | ||
| return errors.Wrapf(err, "get git properties") |
There was a problem hiding this comment.
i think you can keep this wrap, but git prefixes in the other errors make them trackable enough
divolgin
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when go-git encounters an error we end up not printing a very useful error since it ends being unwrapped. e.g.
With this change we should bubble up a more detailed error that should more directly hint at the problem: