Use branches to make releases #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagger/release.go
Outdated
| WithExec([]string{"git", "add", "pkg/version/build.go"}). | ||
| WithExec([]string{"git", "commit", "-m", fmt.Sprintf("Set version to %d.%d.%d", major, minor, patch)}) | ||
| WithExec([]string{"git", "commit", "-m", fmt.Sprintf("Set version to %d.%d.%d", major, minor, patch)}). | ||
| WithExec([]string{"git", "push", "tag", releaseBranchName}). |
There was a problem hiding this comment.
i don't think tag is right here
There was a problem hiding this comment.
this is pushing the branch, right?
There was a problem hiding this comment.
"tag" is the remote and releaseBranchName is the branch name
git push tag release-0.83.11
divolgin
force-pushed
the
divolgin/fix-release
branch
from
fca14ad to
4c5ef18
Compare
dagger/release.go
Outdated
| WithWorkdir("/go/src/github.com/replicatedhq/replicated"). | ||
| WithExec([]string{"git", "remote", "add", "tag", fmt.Sprintf("https://%s@github.com/replicatedhq/replicated.git", githubTokenPlaintext)}). | ||
| With(CacheBustingExec([]string{"git", "tag", fmt.Sprintf("v%d.%d.%d", major, minor, patch)})). | ||
| With(CacheBustingExec([]string{"git", "push", "tag", fmt.Sprintf("v%d.%d.%d", major, minor, patch)})) |
There was a problem hiding this comment.
I think this is needed to push the tag
marccampbell
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.