Skip to content

Do not show created at in the network report #583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2025
Merged

Do not show created at in the network report #583

merged 3 commits into from
Sep 18, 2025

Conversation

jdewinne
Copy link
Member

@jdewinne jdewinne commented Sep 17, 2025 •
edited
Loading

Removes created_at for network reports, and replaces it with the timestamp field from the event data

Example output:

❯ rdev network report 2979703b -w
TIMESTAMP             SRC IP           DST IP           SRC PORT  DST PORT  PROTOCOL  COMMAND          PID       DNS QUERY             SERVICE
2025-09-17 11:03 PDT  10.0.0.11        216.58.210.164   63108     80        TCP       curl             1556      www.google.com        http
2025-09-17 11:03 PDT  10.0.0.11        216.58.210.164   63108     80        TCP       -                -         -                     http
2025-09-17 11:03 PDT  10.0.0.11        216.58.210.164   63108     80        TCP       curl             1556      www.google.com        http
2025-09-17 11:03 PDT  10.0.0.11        216.58.210.164   63108     80        TCP       -                -         -                     http
2025-09-17 11:04 PDT  10.0.0.11        185.125.190.56   1251      123       TCP       chronyd          1038      -                     ntp
2025-09-17 11:04 PDT  10.0.0.11        185.125.190.57   9872      123       TCP       chronyd          1038      -                     ntp
2025-09-17 11:04 PDT  10.0.0.11        91.189.91.157    3973      123       TCP       chronyd          1038      -                     ntp

squizzi
squizzi reviewed Sep 17, 2025
View reviewed changes
cli/print/network_reports.go Outdated
CreatedAt: event.CreatedAt,
EventData: &eventData,
})
// Extract timestamp using the robust ParseTime utility
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robust

@jdewinne jdewinne merged commit 578fb7a into main Sep 18, 2025
5 checks passed
@mikhailswift mikhailswift mentioned this pull request Sep 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squizzi squizzi squizzi left review comments

@mikhailswift mikhailswift mikhailswift approved these changes

Assignees
No one assigned
Labels
type::feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdewinne @squizzi @mikhailswift