Skip to content

Allow ssh/scp while vm is updating #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 18, 2025
Merged

Allow ssh/scp while vm is updating #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
753b0c6
Allow ssh/scp while vm is updating
jdewinne Sep 18, 2025
460cc97
w
jdewinne Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/cmd/vm_endpoints.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ func (r *runners) getVMEndpoint(vmID, endpointType, username string) error {
Status: string(vmFromAPI.Status),
}

if vm.Status != "running" {
return errors.Errorf("VM %s is not in running state (current state: %s). %s is only available for running VMs",
if vm.Status != "running" && vm.Status != "updating" {
return errors.Errorf("VM %s is not in running or updating state (current state: %s). %s is only available for running or updating VMs",
vm.ID, vm.Status, strings.ToUpper(endpointType))
}

Expand Down
2 changes: 1 addition & 1 deletion cli/cmd/vm_endpoints_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ func TestGetVMEndpoint(t *testing.T) {
mockGithubUsername: "testuser",
githubAPIError: false,
expectedOutput: "",
expectedError: "VM vm-123 is not in running state (current state: provisioning). SSH is only available for running VMs",
expectedError: "VM vm-123 is not in running or updating state (current state: provisioning). SSH is only available for running or updating VMs",
},
}

Expand Down