Kots cli release only #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emosbaugh
approved these changes
Sep 16, 2019
cli/cmd/release_update.go
Outdated
| import ( | ||
| "errors" | ||
| "encoding/json" | ||
| // "errors" |
cli/cmd/root.go
Outdated
| return err | ||
| } | ||
| runCmds.appID = app.ID | ||
| } else { |
pkg/shipclient/release.go
Outdated
| Name: shipReleaseChannel.Name, | ||
| } | ||
| activeChannels = append(activeChannels, activeChannel) | ||
|
|
| } | ||
|
|
||
| func (c *Client) UpdateCollectorName(appID string, specID string, name string) (interface{}, error) { | ||
|
|
| return &releaseInfo, nil | ||
| } | ||
|
|
||
| var updateKotsRelease = ` |
There was a problem hiding this comment.
oh I could, that had been the intention - I set the variable then just pasted the mutation directly into the UpdateRelease function. . will fix to as originally intended.
emosbaugh
requested changes
Sep 16, 2019
|
yep - got over eager in deleting code to strip down to just the changes pertaining to the 'release' command. fixed the above, tests passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.