adding channel inspect for ship and kots, release update for ship #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithers1221
changed the title
dexhorthy
reviewed
Oct 28, 2019
client/channel.go
Outdated
| return c.PlatformClient.ArchiveChannel(appID, channelID) | ||
| } else if appType == "ship" { | ||
| // return c.ShipClient.ArchiveChannel(appID, channelID) | ||
| return nil |
There was a problem hiding this comment.
do you think if this finishes without an error, that the user will believe that the channel was archived?
There was a problem hiding this comment.
good point - will add that to the 'sorry, come back later' list.
dexhorthy
reviewed
Oct 28, 2019
| updated | ||
| isDefault | ||
| isArchived | ||
| releases { |
There was a problem hiding this comment.
do we need to fetch every release on the channel?
There was a problem hiding this comment.
@dex - see your point, but can we table that for another PR. Currently pulling from what's on Vendorweb.
dexhorthy
reviewed
Oct 28, 2019
| updated | ||
| isDefault | ||
| isArchived | ||
| releases { |
There was a problem hiding this comment.
same as above, do for fetching channels, do we need to get every release that was published to the channel?
dexhorthy
reviewed
Oct 28, 2019
dexhorthy
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.