kondo-ing the cli #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fshot
suggested changes
Oct 30, 2019
| } else { | ||
| } else if appType == "ship" { | ||
| return c.ShipClient.PromoteCollector(appID, specID, channelIDs...) | ||
| } |
There was a problem hiding this comment.
Is it intentional that we're not specifically explaining that Kots apps collectors are handled differently, as we do with the CreateCollector call above?
There was a problem hiding this comment.
My thought was that to call this you actual need to have created a spec and have a specID...which would be impossible if it was a kots app.
client/entitlements.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| func (c *Client) CreateEntitlementSpec(name string, appType string, spec string, appID string) (*types.EntitlementSpec, error) { |
There was a problem hiding this comment.
It's a little weird that every other function starts with appID and AppType as the first two parameters, and this one starts with the 'name' parameter. Updating this for consistency would be a good idea, unless there's a strong reason otherwise.
There was a problem hiding this comment.
totally - will change right now.
fshot
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.