Reflect cypress 10 changes for getTotalSpecs #123
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @dwentland24 ! |
|
@AmsterGet I pushed a revised version as #126 |
|
Closed in favor of #126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cypress 10 updated its configuration structure. Refactored the part to get the total number of specs for the run. Now the reporter should supports cypress 10. I had no further issues within our test repository.
The changes resulted in not finishing launches if eg.
autoMergeoptions was used. To finish the launch the current and total number of specs needs to be equal. Due to different naming and removed properties in the config of cypress 10 the number of total specs got calculated wrong.Refactored the method and add some helper functions.
Also extend the unit tests.
May solve this issue: #116