Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reflect cypress 10 changes for getTotalSpecs #126

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Reflect cypress 10 changes for getTotalSpecs #126

merged 1 commit into from
Sep 20, 2022

Conversation

orgads
Copy link
Contributor

@orgads orgads commented Aug 28, 2022 •
edited
Loading

Fixes #116.

Reviving #123

@orgads orgads mentioned this pull request Aug 28, 2022
Closed
@orgads
Copy link
Contributor Author

orgads commented Aug 30, 2022

ping

@orgads
Copy link
Contributor Author

orgads commented Sep 2, 2022

@AmsterGet?

orgads pushed a commit to orgads/agent-js-cypress that referenced this pull request Sep 5, 2022
@dwentland24 @orgads
Reflect cypress 10 changes for getTotalSpecs
735de95 
Fixes reportportal#126.
@orgads orgads force-pushed the fix-count-total-specs-cypres-10 branch from 8bf8e27 to 735de95 Compare September 5, 2022 10:37
@orgads
Copy link
Contributor Author

orgads commented Sep 5, 2022

Confirmed it fixes the issue.

@orgads orgads force-pushed the fix-count-total-specs-cypres-10 branch from 735de95 to 1a63c0f Compare September 5, 2022 10:38
@orgads orgads mentioned this pull request Sep 5, 2022
Closed
@AmsterGet
Copy link
Member

Hello @orgads !
I'm currently on vacation and plan to finish the review and publish your changes after Thursday this week.
Sorry for the delay in replies.

@orgads
Copy link
Contributor Author

orgads commented Sep 5, 2022

Thank you very much.

@orgads
Copy link
Contributor Author

orgads commented Sep 12, 2022

Hi. Kind reminder :)

@AmsterGet
Copy link
Member

AmsterGet commented Sep 13, 2022 •
edited
Loading

@orgads don't worry, I'm in progress with it :)

@AmsterGet AmsterGet linked an issue Sep 20, 2022 that may be closed by this pull request
Error thrown when spec finishes for new Cypress 10 #116
Closed
@AmsterGet
Copy link
Member

Thank you very much @orgads !
It will go to 5.0.5.
ETA - upcoming sprint (current week/beginning of the next week).

@AmsterGet AmsterGet merged commit 0863215 into reportportal:develop Sep 20, 2022
@orgads orgads deleted the fix-count-total-specs-cypres-10 branch September 20, 2022 08:37
@orgads
Copy link
Contributor Author

orgads commented Sep 20, 2022

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmsterGet AmsterGet AmsterGet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error thrown when spec finishes for new Cypress 10
3 participants
@orgads @AmsterGet @dwentland24