Skip to content

Make bearer auth per session instead of per request #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2017

Conversation

krasoffski
Copy link
Contributor

@krasoffski krasoffski commented May 11, 2017

Previous commit introduced BearerAuth class. It adds for each request required auth header (call for each request) which is not necessary in the current implementation because token is not changed during session. Moreover, it performs string formatting operation for each request which is slightly slower.

  • Move auth header to session scope due to reasons described above.

@avarabyeu avarabyeu merged commit db9e3f7 into reportportal:master May 11, 2017
@krasoffski krasoffski deleted the bearer-perf branch May 11, 2017 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants