A few minor fixes: #1591
Merged
A few minor fixes: #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved `removeRefererHeader` to the appropriate section of the options docs - Pass `options` to the redirect's module `onRequest` method, as it makes it more obvious from where these options are coming from (the extending of the request object in the ctor is a bit unexpected to say the least) - Attached the `debug` function to the request's prototype to make it accessible to the modules through the request instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removeRefererHeaderto the appropriate section of the options docsoptionsto the redirect's moduleonRequestmethod, as it makes it more obvious from where these options are coming from (the extending of the request object in the ctor is a bit unexpected to say the least)debugfunction to the request's prototype to make it accessible to the modules through the request instanceThis also fixes the
request.debugcall in theharmodule, which obviously is not covered by the tests atm, or rather it should be obvious if coveralls was actually working ..