Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few minor fixes: #1591

Merged
merged 1 commit into from May 23, 2015

Conversation

Projects
None yet
1 participant
@simov
Copy link
Member

commented May 20, 2015

  • Moved removeRefererHeader to the appropriate section of the options docs
  • Pass options to the redirect's module onRequest method, as it makes it more obvious from where these options are coming from (the extending of the request object in the ctor is a bit unexpected to say the least)
  • Attached the debug function to the request's prototype to make it accessible to the modules through the request instance

    This also fixes the request.debug call in the har module, which obviously is not covered by the tests atm, or rather it should be obvious if coveralls was actually working ..
A few minor fixes:
- Moved `removeRefererHeader` to the appropriate section of the options docs
- Pass `options` to the redirect's module `onRequest` method, as it makes it more obvious from where these options are coming from (the extending of the request object in the ctor is a bit unexpected to say the least)
- Attached the `debug` function to the request's prototype to make it accessible to the modules through the request instance

simov added a commit that referenced this pull request May 23, 2015

Merge pull request #1591 from simov/fixes
A few minor fixes:

@simov simov merged commit f2451bf into request:master May 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.