Honor the .strictSSL option when using proxies (tunnel-agent) #508

Merged
merged 1 commit into from Apr 13, 2013

Projects

None yet

2 participants

@jhs
Contributor
jhs commented Apr 8, 2013

Using a proxy makes Request use its own agent. Therefore, Request must give the agent the appropriate rejectUnauthorized value.

Thanks, Isaac Schlueter for a hint of where to look for this bug.

@jhs jhs commented on the diff Apr 8, 2013
@@ -445,6 +446,7 @@ Request.prototype._updateProtocol = function () {
var tunnelOptions = { proxy: { host: self.proxy.hostname
, port: +self.proxy.port
, proxyAuth: self.proxy.auth }
+ , rejectUnauthorized: self.rejectUnauthorized
, ca: self.ca }
@jhs
jhs Apr 8, 2013 Contributor

BTW, this part, _updateProtocol is a bit of code duplication from above, and note that it has already drifted. This one uses self.ca and the other uses this.ca. Since it is unrelated to my bug, I did not change it.

@mikeal mikeal merged commit 93e7c20 into request:master Apr 13, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment