-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
footer: update links #868
footer: update links #868
Conversation
6ea304b
to
9df9dae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why put the text in PDF? Wouldn't it be better to do it in html?
{% set link = 'https://www.rero.ch/de/products/sonar' if current_i18n.locale.language == 'de' else 'https://www.rero.ch/produits/sonar' %} | ||
{% trans %}Powered by <a href="{{ link }}" target="_blank" rel="noopener">SONAR</a>{% endtrans %} | ||
{% trans %}Powered by <a href="https://www.rero.ch/produits/sonar" target="_blank" rel="noopener">SONAR</a>{% endtrans %} | | ||
{{ _('Version') }} <a href="https://github.com/rero/sonar">{{ version }}</a> | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can perhaps include the right tag to the github link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
{% trans %}Powered by <a href="{{ link }}" target="_blank" rel="noopener">SONAR</a>{% endtrans %} | ||
{% trans %}Powered by <a href="https://www.rero.ch/produits/sonar" target="_blank" rel="noopener">SONAR</a>{% endtrans %} | | ||
{{ _('Version') }} <a href="https://github.com/rero/sonar">{{ version }}</a> | | ||
<a href="https://www.rero.ch/legal/privacy/declaration_protection_donnees_SONAR.pdf">{{ _('Privacy policy') }}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only in french?
* Updates links to rero.ch * Adds current version number in footer * Adds link to privacy policy Co-Authored-by: Pascal Repond <pascal.repond@rero.ch>
Co-Authored-by: Pascal Repond pascal.repond@rero.ch