-
Notifications
You must be signed in to change notification settings - Fork 332
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Create objects for delegating components (#3303)
### What Builds on top of: #3302 One of the items raised by #3268 was wanting to extend a component type. But components previously had no instantiation. This PR creates Component objects that derive from their baseclass as well as the extension class. These can be used anywhere the datatype could be used instead. Example with TextLogLevel: ``` >>> rr2.TextLog(body="Hello", level=rr2.cmp.TextLogLevel.WARN) rr.TextLog( rerun.label<string>( ['Hello'] ) rerun.components.TextLogLevel<string>( ['WARN'] ) rerun.colorrgba<uint32>( [] ) ) >>> rr2.TextLog(body="World", level=rr2.cmp.TextLogLevel("my custom level")) rr.TextLog( rerun.label<string>( ['World'] ) rerun.components.TextLogLevel<string>( ['my custom level'] ) rerun.colorrgba<uint32>( [] ) ) ``` ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3303) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/3303) - [Docs preview](https://rerun.io/preview/177f58319e85da35d223c1fd0a109d35fbc7bd03/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/177f58319e85da35d223c1fd0a109d35fbc7bd03/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://ref.rerun.io/dev/bench/) - [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
- Loading branch information
Showing
28 changed files
with
413 additions
and
142 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
580101e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
1.25
.mono_points_arrow/decode_message_bundles
71179548
ns/iter (± 715465
)54762985
ns/iter (± 1074225
)1.30
This comment was automatically generated by workflow using github-action-benchmark.