Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport Points2D archetype into existing Python SDK #2386

Closed
teh-cmc opened this issue Jun 12, 2023 · 0 comments · Fixed by #2601
Closed

Backport Points2D archetype into existing Python SDK #2386

teh-cmc opened this issue Jun 12, 2023 · 0 comments · Fixed by #2601
Assignees
@abey79
Labels
codegen/idl 🐍 Python API Python logging API

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 12, 2023 •
edited

It should be possible to start using the new object-oriented Points2D archetype from the current Python SDK, today.

This will require a new generic log function that must coexist peacefully with the existing API.
I.e. calling log_points() or log(Points2D(..)) should both be legal and behave similarly.

This will allow us to start migrating step-by-step to both the object-oriented API and the codegen stack.

TODO:

  • Points2D must be able to do everything that log_points does
  • We need a new generic log function that can log any archetype
    • Either a freestanding thing
    • Or generated as a method on every archetypes

Requires #2384
@teh-cmc teh-cmc added 🐍 Python API Python logging API codegen/idl labels Jun 12, 2023
@teh-cmc teh-cmc assigned teh-cmc and abey79 and unassigned teh-cmc Jun 27, 2023
@teh-cmc teh-cmc mentioned this issue Jul 6, 2023
Merged
3 tasks
@teh-cmc teh-cmc closed this as completed in 4360deb Jul 6, 2023
teh-cmc added a commit that referenced this issue Jul 6, 2023
@teh-cmc
End-to-end cross-language roundtrip tests for our archetypes (#2601)
6cb2c68 
With this PR, the CI will now compare the results of logging our
archetypes across all of our SDKs.

You can run it locally with:
```
./scripts/ci/run_e2e_roundtrip_tests.py --no-build
```

E.g.:

![image](https://github.com/rerun-io/rerun/assets/2910679/38f1541e-20ef-4ebd-8d55-ee6215fefd3c)


Requires #2597 

Fixes #2383 
Fixes #2384 
Fixes #2386 

---

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2601) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2601)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Fend_to_end_roundtrips_ci/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fend_to_end_roundtrips_ci/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abey79 abey79

Labels
codegen/idl 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

End-to-end cross-language roundtrip tests for our archetypes rerun-io/rerun
2 participants
@teh-cmc @abey79