Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbed SpaceViews don't activate when selected from the Blueprint Tree UI and an egui_tile warning is printed instead #2814

Closed
abey79 opened this issue Jul 25, 2023 · 2 comments · Fixed by #3295
Closed

Tabbed SpaceViews don't activate when selected from the Blueprint Tree UI and an egui_tile warning is printed instead #2814

abey79 opened this issue Jul 25, 2023 · 2 comments · Fixed by #3295
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working ui concerns graphical user interface
Milestone
0.9 - Codegen, Ty...

Comments

@abey79
Copy link
Member

abey79 commented Jul 25, 2023 •
edited
Loading

Describe the bug

When selecting a SpaceView in the Blueprint Tree UI which corresponds to a tab that is hidden, it is expected that the corresponding tab is brought to front. It currently doesn't. This might be due to egui_tiles' make_active(), which emits warning such as:

 egui_tiles::tiles] Failed to find tile #3 during make_active

This happens in viewport_blueprint_ui.rs's focus_tab() function.
@abey79 abey79 added the 🪳 bug Something isn't working label Jul 25, 2023
@abey79 abey79 added this to the 0.9 milestone Aug 7, 2023
@emilk emilk modified the milestones: 0.9, 0.8.2 Aug 23, 2023
@emilk
Copy link
Member

emilk commented Aug 25, 2023 •
edited
Loading

If we can't find this quickly, let's just mute the warnings from egui_tiles in release so we don't spam the user

@emilk emilk added the 😤 annoying Something in the UI / SDK is annoying to use label Aug 25, 2023
@abey79 abey79 changed the title Spurious warnings when clicking space views in the blueprint tree Tabbed SpaceViews don't activate when selected from the Blueprint Tree UI and an egui_tile warning is printed instead Aug 25, 2023
@abey79
Copy link
Member Author

abey79 commented Aug 26, 2023

I bisected that and the culprit is, somewhat unsurprisingly, ec0c7cf. So somewhere in #2465 or rerun-io/egui_tiles#7.

@emilk emilk added the ui concerns graphical user interface label Sep 11, 2023
@emilk emilk mentioned this issue Sep 12, 2023
Merged
3 tasks
@emilk emilk self-assigned this Sep 12, 2023
emilk added a commit that referenced this issue Sep 13, 2023
@emilk
Improve viewport tile behavior (#3295)
4c9753e 
### What
* Closes #2880
* Closes #2814
* Includes an update to rerun-io/egui_tiles#26

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3295) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3295)
- [Docs
preview](https://rerun.io/preview/bc86183c16f8c2c0e1097bcf0386995e6f425900/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/bc86183c16f8c2c0e1097bcf0386995e6f425900/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
@emilk emilk removed their assignment Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Milestone
0.9 - Codegen, Type Oriented Api
Development

Successfully merging a pull request may close this issue.

Improve viewport tile behavior rerun-io/rerun
2 participants
@emilk @abey79