-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New container/space view addition workflow #4492
Labels
ui
concerns graphical user interface
Comments
abey79
added
ui
concerns graphical user interface
🎄 tracking issue
issue that tracks a bunch of subissues
and removed
🎄 tracking issue
issue that tracks a bunch of subissues
labels
Dec 12, 2023
This was referenced Dec 12, 2023
5 tasks
abey79
added a commit
that referenced
this issue
Jan 4, 2024
…ierarchy (#4616) ### What This is an initial take for the new so-called "additive workflow", which enables building a hierarchy of container and space views from scratch. It involves the following changes in UX: - The automatic simplification of the container tree is (mostly) disabled, as empty containers must be (temporarily) allowed while building a hierarchy. - Instead, a new "Simplify Container" button is available in the Selection Panel to simplify the subtree under the selected container. - A list if container children is displayed in the container Selection Panel, with a button to add more. - A new "Add Container or Space View" modal makes it possible to add a container and/or a space view of any type in the selected container. This feature is gated behind an experimental flag (Rerun Menu -> Options -> Enable the container addition workflow). <img width="1248" alt="image" src="https://github.com/rerun-io/rerun/assets/49431240/0b58c298-d75c-480e-a88d-c1a5fe2265f5"> ~~This PR also reorganises the experimental flags in the rerun menu such that they are visible in web and release builds.~~ (superseded by #4661) Fixes #4492 Fixes #4493 #### TODO (not necessarily in this PR) - [x] Fix the hover/click UI of the big PLUS button in the modal. - The PLUS button in the blueprint tree panel still shows the older menu. This should reunified somehow (when we figure out how we want the heuristics to show up): #4652 - Lots of container tree behaviour edge case to identify and fix. - The modal really needs the new icons #4321 - Better hover highlight in the modal: #4673 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4616/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4616/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4616/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4616) - [Docs preview](https://rerun.io/preview/044dfdff939ae0e7bfa7effd2533a1026a11dd0f/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/044dfdff939ae0e7bfa7effd2533a1026a11dd0f/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) --------- Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is about completing the design and implementation of the new container/space view addition workflow, including:
Design
Implementation
cc @martenbjork
The text was updated successfully, but these errors were encountered: