Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DepthImage backprojection doesn't set up correctly if the same entity is used for camera and image #4644

Closed
kpreid opened this issue Jan 2, 2024 · 3 comments · Fixed by #4679
Assignees
Labels
🪳 bug Something isn't working
Milestone

Comments

@kpreid
Copy link
Collaborator

kpreid commented Jan 2, 2024

Possibly the same sort of thing as #3296, but I can reproduce this on the latest code b4768f3 .

Describe the bug
If a DepthImage and Pinhole are logged to the same entity, the backprojection will fail to render because the meter value is 0. Yet, it works fine if the value is manually changed.

To Reproduce
Steps to reproduce the behavior:

  1. Modify code-examples/depth_image_3d.rs so that both log() operations use the same entity path.
  2. cargo run --bin rerun
  3. cargo run --bin depth_image_3d
  4. Observe that no backprojected depth appears.
  5. Select the 3D view of the entity and observe that "Backproject meter" is equal to 0.

Expected behavior
The logged meter value should be respected.

Screenshots
image

Desktop (please complete the following information):

  • OS: macOS Sonoma 14.2.1 (23C71)

Rerun version
rerun-cli 0.12.0-alpha.3 [rustc 1.74.0 (79e9716c9 2023-11-13), LLVM 17.0.4] x86_64-apple-darwin

Also reproduces with released rerun 0.11

@kpreid kpreid added 👀 needs triage This issue needs to be triaged by the Rerun team 🪳 bug Something isn't working labels Jan 2, 2024
@kpreid
Copy link
Collaborator Author

kpreid commented Jan 3, 2024

Per discussion at #4627 (comment) , maybe this sort of thing (multiple non-transform archetypes on the same path) isn't even supposed to be supported. But if so, there aren't really signposts against it, and #2568 specifically added support for a related case.

@Wumpf
Copy link
Member

Wumpf commented Jan 4, 2024

maybe this sort of thing (multiple non-transform archetypes on the same path) isn't even supposed to be supported

Generally, logging anything where components don't overwrite each other is fine. But we don't have a nice way of communicating that yet

@Wumpf Wumpf removed the 👀 needs triage This issue needs to be triaged by the Rerun team label Jan 4, 2024
@Wumpf Wumpf self-assigned this Jan 4, 2024
@Wumpf
Copy link
Member

Wumpf commented Jan 4, 2024

This is definitely not a case where components overlap, this should just work. But somehow the supplied meter is ignored. I'm investigating

Wumpf added a commit that referenced this issue Jan 5, 2024
…hMeter being ignored sometimes (#4679)

### What

* Fixes #4644 

The way we updated properties for auto-property values made it pretty
much random (not literally, but feels as-if) when and when not we'd see
updated `EditableAutoValue::Auto` values!

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4679/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4679/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4679/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4679)
- [Docs
preview](https://rerun.io/preview/7f911b822059b82883b2e8d1a909819ab618ff46/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/7f911b822059b82883b2e8d1a909819ab618ff46/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
@Wumpf Wumpf added this to the 0.12 milestone Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working
Projects
None yet
2 participants