Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't completely remove group in blueprint panel #5835

Closed
nikolausWest opened this issue Apr 8, 2024 · 2 comments · Fixed by #5840
Closed

Can't completely remove group in blueprint panel #5835

nikolausWest opened this issue Apr 8, 2024 · 2 comments · Fixed by #5840
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Milestone
0.15

Comments

@nikolausWest
Copy link
Member

Found on web version of the 0.15 release branch here

See video
https://github.com/rerun-io/rerun/assets/2624717/9830cc5d-4956-417b-9b40-5e947568e7c4

Also: hovering the entity still shows the old message that refers to groups, which is confusing.
@nikolausWest nikolausWest added 🪳 bug Something isn't working ui concerns graphical user interface labels Apr 8, 2024
@nikolausWest nikolausWest added this to the 0.15 milestone Apr 8, 2024
@abey79
Copy link
Member

abey79 commented Apr 8, 2024

So we decided to always show the origin, regardless of whether it shows up in data result or not. But clearly the —button shouldn't be there. Taking a look 👀

@abey79 abey79 mentioned this issue Apr 8, 2024
Merged
5 tasks
@nikolausWest
Copy link
Member Author

So we decided to always show the origin, regardless of whether it shows up in data result or not. But clearly the —button shouldn't be there. Taking a look 👀

Alright, I didn't realize that. It's pretty confusing but I can see why you made that decision. Important that the tooltip is descriptive in that case as well then

abey79 added a commit that referenced this issue Apr 8, 2024
@abey79
Do not show the remove button when the origin is empty (#5840)
efca999 
### What

- Closes #5835

<img width="291" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/6a7a204a-53d8-48ec-8e31-3f08619380ea">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[rerun.io/viewer](https://rerun.io/viewer/pr/5840)
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5840?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5840?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5840)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
abey79 added a commit that referenced this issue Apr 8, 2024
@abey79
Do not show the remove button when the origin is empty (#5840)
d321387 
### What

- Closes #5835

<img width="291" alt="image"
src="https://github.com/rerun-io/rerun/assets/49431240/6a7a204a-53d8-48ec-8e31-3f08619380ea">


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[rerun.io/viewer](https://rerun.io/viewer/pr/5840)
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5840?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/5840?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/5840)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🪳 bug Something isn't working ui concerns graphical user interface
Projects
None yet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

Do not show the remove button when the origin is empty rerun-io/rerun
2 participants
@nikolausWest @abey79