Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform hierarchy is not affected by blueprint overrides #6743

Open
Wumpf opened this issue Jul 3, 2024 · 0 comments
Open

Transform hierarchy is not affected by blueprint overrides #6743

Wumpf opened this issue Jul 3, 2024 · 0 comments
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working

Comments

@Wumpf
Copy link
Member

Wumpf commented Jul 3, 2024

A prototype exists on the andreas/transform-overrides branch, but holding on to this prior to 0.17 since it requires a few rather ugly changes and isn't quite complete yet.

@Wumpf Wumpf added 🪳 bug Something isn't working 🟦 blueprint The data that defines our UI labels Jul 3, 2024
Wumpf added a commit that referenced this issue Jul 16, 2024
### What

* Part of #6831
* Followed by #6892

Starts the process of splitting up `Transform3D` into several
components.
Far from done overall, but establishes a lot of the new documentation &
test patterns for this effort.

This PR fully replaces the `TranslationAndMat3x3` variant & datatype and
puts `Translation3D` & `TransformMat3x3` into existence and to work.
It does not touch on anything directly related to out of tree transforms
and does not do away from the `Transform3D` component yet.

I added a new component edit/view ui for consistency:
<img width="532" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/1e7122f0-bf27-4f50-bc23-2824c2607ab2">


<img width="552" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/1b30af25-905f-49ed-952b-961350dfab1f">
Unfortunately, transform hierarchy doesn't get affected by overrides yet
(see #6743), which is why I had
to turn off editing itself for the moment. Also, we don't yet show
multiline on hover, so matrix3x3 inspection regressed a little bit for
the moment (part of the only partially solved
#6661)


### Checklist
* [x] pass `main` ci checks
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6866?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6866?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!
* [x] If have noted any breaking changes to the log API in
`CHANGELOG.md` and the migration guide

- [PR Build Summary](https://build.rerun.io/pr/6866)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI 🪳 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant