Remove the redundant costly transform check during categorization #1695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
commented
Mar 23, 2023
| entity_path, | ||
| &LatestAtQuery::new(timeline, TimeInt::MAX), | ||
| ) | ||
| .is_some() |
There was a problem hiding this comment.
Given this is a query over all time anyways, this seems completley redundant with the below, faster, check of simply, "Does this entity path include a transform component"
Wumpf
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
I think at some point this was there to ensure that cameras would be classified as 3d, but yeah I don't see how this makes sense anymore
Looks like this fell out of the confusing times of arrow transition
Upper check was added here 7cd1f33
and then lower check here as an "arrow only fix" (??) aa09fe4
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell this check is redundant and the overhead adds up when we have a large number of transforms.
This shaves about 6ms off of
all_possible_space_viewsin the raw_mesh example.Before:
After:
Checklist