Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remember to decode JPEGs #1884

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Remember to decode JPEGs #1884

merged 4 commits into from
Apr 18, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Apr 17, 2023

Closes #1877

Statically ensure we decode tensors (e.g. jpegs) before we try to upload them to GPU.

Checklist

@emilk emilk added the 🪳 bug Something isn't working label Apr 17, 2023
jleibs
jleibs approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit on adding an extra check when we construct the DecodedTensor but otherwise looks good.

crates/re_viewer/src/misc/caches/tensor_decode_cache.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit a1289fa into main Apr 18, 2023
@emilk emilk deleted the emilk/fix-jpeg-decoding branch April 18, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JPEGs not decoded when hovering
2 participants
@emilk @jleibs