Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D layering fixes #2080

Merged
merged 6 commits into from
May 15, 2023
Merged

2D layering fixes #2080

merged 6 commits into from
May 15, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented May 10, 2023

  • fix layered images (same draw order) no longer being transparent
  • fix z fighting in some cases
  • improved draw order sample

image

Checklist

PR Build Summary: https://build.rerun.io/pr/2080

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release 🪳 bug Something isn't working labels May 10, 2023
@teh-cmc teh-cmc self-requested a review May 12, 2023 07:23
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine but I was extremely surprised and confused by the fact that drawing two opaque images on the same plane suddenly resulted into blending? I've missed a discussion I guess 🤔

@Wumpf
Copy link
Member Author

Wumpf commented May 12, 2023

I've missed a discussion I guess

hmm not really. That's just "how it's always been". I think someone at some point pointed out that this behavior should be configurable in some way. But the behavior changing was unintentional and thus considered a regression

@Wumpf Wumpf merged commit a64edaa into main May 15, 2023
@Wumpf Wumpf deleted the andreas/2d-layering-fixes branch May 15, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants