Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add delete buttons in the Recordings UI #2976

Merged
merged 6 commits into from
Aug 16, 2023
Merged

Add delete buttons in the Recordings UI #2976

merged 6 commits into from
Aug 16, 2023

Conversation

abey79
Copy link
Member

@abey79 abey79 commented Aug 14, 2023 •
edited
Loading

What

As the title says. Also fixes StoreHub::remove_recording_id() to only change selection if the currently selected recording is being removed (otherwise the selection remains unchanged).

TODO:

image

Checklist

@abey79 abey79 added ui concerns graphical user interface do-not-merge Do not merge this PR labels Aug 14, 2023
emilk
emilk approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@abey79 abey79 removed the do-not-merge Do not merge this PR label Aug 16, 2023
emilk
emilk reviewed Aug 16, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can I see the text wrapping in action? I tried the link in the PR description and got:

image

EDIT: it works now. The demo link is a bit slow to update sometimes

crates/re_ui/src/list_item.rs Outdated Show resolved Hide resolved
abey79 and others added 2 commits August 16, 2023 13:30
@abey79 @emilk
Update crates/re_ui/src/list_item.rs
82b8ec8 
Co-authored-by: Emil Ernerfeldt <emil.ernerfeldt@gmail.com>
@abey79
Fix TextWrapping
b0bec06
@abey79 abey79 merged commit d58ee96 into main Aug 16, 2023
23 checks passed
@abey79 abey79 deleted the antoine/recording-close-button branch August 16, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abey79 @emilk