Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rerun print: print just summary, unless given --verbose #5079

Merged
merged 5 commits into from
Feb 7, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 7, 2024

What

Added when debugging #5078

Example:

> rerun print nuscenes.rrd

StoreInfo {
    application_id: ApplicationId(
        "rerun_example_nuscenes",
    ),
    store_id: StoreId {
        kind: Recording,
        id: "58821cc9-d39c-4f78-9e7e-bad4933e9870",
    },
    is_official_example: true,
    started: "2024-02-06 12:34:04.306130Z",
    store_source: PythonSdk(
        3.11.6,
    ),
    store_kind: Recording,
}
StoreInfo {
    application_id: ApplicationId(
        "rerun_example_nuscenes",
    ),
    store_id: StoreId {
        kind: Recording,
        id: "58821cc9-d39c-4f78-9e7e-bad4933e9870",
    },
    is_official_example: true,
    started: "2024-02-06 12:34:04.306130Z",
    store_source: PythonSdk(
        3.11.6,
    ),
    store_kind: Recording,
}
Table with 596 rows (90.6 MiB). Columns: ["Color", "ImageIndicator", "InstanceKey", "PinholeIndicator", "PinholeProjection", "Points3DIndicator", "Position3D", "Resolution", "TensorData", "Transform3D", "Transform3DIndicator", "ViewCoordinates", "ViewCoordinatesIndicator"]
Table with 586 rows (12.0 MiB). Columns: ["Color", "ImageIndicator", "InstanceKey", "Points3DIndicator", "Position3D", "TensorData"]
Table with 179 rows (244 KiB). Columns: ["Boxes3DIndicator", "ClassId", "Color", "HalfSizes3D", "InstanceKey", "Points3DIndicator", "Position3D", "Rotation3D"]

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added include in changelog CLI Related to the Rerun CLI labels Feb 7, 2024
@emilk emilk marked this pull request as ready for review February 7, 2024 09:34
crates/re_log_types/src/lib.rs Outdated Show resolved Hide resolved
@@ -231,7 +231,7 @@ fn test_parse_bytes_base10() {
}

pub fn parse_bytes_base2(bytes: &str) -> Option<i64> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that the function we use to parse user input in env variables? i'm a bit worried to see it being case-sensitive, that's gonna trip up a lot of people...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt anyone is specifying a memory limit in KiB, so I think this small breaking change can slip though.

As for case insensitive: I don't think we should parse Mib (Mebi-bits) as MiB (Mebi-bytes). that could trip someone up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment about it

@emilk emilk merged commit dd18b03 into main Feb 7, 2024
40 checks passed
@emilk emilk deleted the emilk/improve-print branch February 7, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI Related to the Rerun CLI include in changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants