Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ListItem bugs #6398

Merged
merged 10 commits into from
May 24, 2024
Merged

Fix ListItem bugs #6398

merged 10 commits into from
May 24, 2024

Conversation

emilk
Copy link
Member

@emilk emilk commented May 21, 2024 •
edited by github-actions bot
Loading

What

First bug: scrolling would make columns expand/collapse
Second bug: id clashes (found by selecting multiple space views)

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface exclude from changelog PRs with this won't show up in CHANGELOG.md labels May 21, 2024
abey79
abey79 requested changes May 23, 2024
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id change broke the "Expend/Collapse all" functionality.

Other than that, lgtm!

crates/re_ui/src/list_item.rs Outdated Show resolved Hide resolved
@emilk emilk changed the title Fix ListItem bugs Fix ListItem bugs May 23, 2024
@emilk emilk requested a review from abey79 May 23, 2024 11:27
abey79
abey79 approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@abey79 abey79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

crates/re_time_panel/src/lib.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 70dae59 into main May 24, 2024
27 of 28 checks passed
@emilk emilk deleted the emilk/list-item-fixes branch May 24, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abey79 abey79 abey79 approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working exclude from changelog PRs with this won't show up in CHANGELOG.md ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilk @abey79