Introduce a checklist for visualizers, overrides etc #6727
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Play with it live.
This adds a checklist that tries to cover as much as possible of the visualizer/overrides/defaults/etc stack with as little maintenance overhead as possible.
Once we're happy with it, we can derive it for different views/visualizers if there are specific things we want to check for.
This checks that adding and removing overrides & defaults work as expected for 2D views (both from the UI and from the SDK), and that they do the right thing rendering wise (using JPEGs as reference).
Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.