Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a checklist for visualizers, overrides etc #6727

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Jul 2, 2024

Play with it live.

This adds a checklist that tries to cover as much as possible of the visualizer/overrides/defaults/etc stack with as little maintenance overhead as possible.

Once we're happy with it, we can derive it for different views/visualizers if there are specific things we want to check for.

This checks that adding and removing overrides & defaults work as expected for 2D views (both from the UI and from the SDK), and that they do the right thing rendering wise (using JPEGs as reference).

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added 🔨 testing testing and benchmarks 🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md labels Jul 2, 2024
@Wumpf Wumpf self-requested a review July 3, 2024 13:15
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

tests/python/release_checklist/check_overrides_2d.py Outdated Show resolved Hide resolved
tests/python/release_checklist/check_overrides_2d.py Outdated Show resolved Hide resolved
@teh-cmc
Copy link
Member Author

teh-cmc commented Jul 4, 2024

Made a bunch of changes according to your feedback -- that's much better I think 👍

I'll wait for #6741 to be merged before finalizing this though, as this will change the expected results.


---

👏👏👏
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more clapping than before. Very good 😄

@teh-cmc teh-cmc merged commit 2c8c34d into main Jul 4, 2024
28 of 31 checks passed
@teh-cmc teh-cmc deleted the cmc/checklist_overrides branch July 4, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🟦 blueprint The data that defines our UI exclude from changelog PRs with this won't show up in CHANGELOG.md 🔨 testing testing and benchmarks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants