-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/cleanup our pixi tasks #6864
Conversation
Deployed docs
|
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9892318022 |
5a26ced
to
30f8401
Compare
@rerun-bot full-check |
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9894749098 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great docs! I tried a few commands locally (Mac) and it seems to work fine.
|
||
[feature.python-tasks.tasks] | ||
|
||
py-build = "pixi run -e py py-build-common" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes problems when running docs/snippets/compare_snippet_output.py
, since it build the python wheel to a different environment than the one running the snippets.
We either need to add -e py
to all python invocations in compare_snippet_output.py
(but I think that will break CI, which calls compare_snippet_output.py
with -e wheel-test
), or call py-build-common
from compare_snippet_output.py
instead of py-build
. But then I wonder - what is the py-build
command for?
Setting the environment inside the environment like this seems like an inherently bad idea since it means the environment the user asked for will be ignored
What
pixi run py-test
fails withundefined reference to
memfd_create'` #6852Most notably, this introduces a new
py
environment to mirror thecpp
environment.py-build
is now scoped to that environment, withpy-build-examples
being a dedicated task scoped to the examples environment.Checklist
main
build: rerun.io/viewernightly
build: rerun.io/viewerCHANGELOG.md
and the migration guideTo run all checks from
main
, comment on the PR with@rerun-bot full-check
.