Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cleanup our pixi tasks #6864

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Fix/cleanup our pixi tasks #6864

merged 4 commits into from
Jul 11, 2024

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Jul 11, 2024

What

Most notably, this introduces a new py environment to mirror the cpp environment.

py-build is now scoped to that environment, with py-build-examples being a dedicated task scoped to the examples environment.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@jleibs jleibs added the 🧑‍💻 dev experience developer experience (excluding CI) label Jul 11, 2024
@jleibs jleibs marked this pull request as ready for review July 11, 2024 13:21
Copy link

github-actions bot commented Jul 11, 2024

Deployed docs

Commit Link
60382b3 https://landing-diov4aimy-rerun.vercel.app/docs

@jleibs jleibs added the exclude from changelog PRs with this won't show up in CHANGELOG.md label Jul 11, 2024
@jleibs
Copy link
Member Author

jleibs commented Jul 11, 2024

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9892318022

@jleibs jleibs force-pushed the jleibs/pixi_python_task_cleanup branch from 5a26ced to 30f8401 Compare July 11, 2024 14:57
@jleibs
Copy link
Member Author

jleibs commented Jul 11, 2024

@rerun-bot full-check

Copy link

Started a full build: https://github.com/rerun-io/rerun/actions/runs/9894749098

@Wumpf Wumpf self-requested a review July 11, 2024 16:02
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs! I tried a few commands locally (Mac) and it seems to work fine.

@jleibs jleibs merged commit 82f9682 into main Jul 11, 2024
73 of 74 checks passed
@jleibs jleibs deleted the jleibs/pixi_python_task_cleanup branch July 11, 2024 17:50

[feature.python-tasks.tasks]

py-build = "pixi run -e py py-build-common"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This causes problems when running docs/snippets/compare_snippet_output.py, since it build the python wheel to a different environment than the one running the snippets.

We either need to add -e py to all python invocations in compare_snippet_output.py (but I think that will break CI, which calls compare_snippet_output.py with -e wheel-test), or call py-build-common from compare_snippet_output.py instead of py-build. But then I wonder - what is the py-build command for?

Setting the environment inside the environment like this seems like an inherently bad idea since it means the environment the user asked for will be ignored

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧑‍💻 dev experience developer experience (excluding CI) exclude from changelog PRs with this won't show up in CHANGELOG.md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pixi run py-test fails with undefined reference to memfd_create'`
3 participants