Initial playground #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- UseScript loading mechanism to load the compiler bundle from and external url - Render the loading state of the script
Hooks up error reporting with codemirror as well (really rough rn)
This introduces a new concept of a `FinalResult`, that unifies a CompilationResult.t and ConvertionResult.t. This makes sure we are not getting out of sync with the error messages in the error pane. Also it makes it easier to separate between pure syntax parsing results and actual compilation results.
More specifically, there was a bug where pressing the `format` button would not trigger a codemirror content sync, since the input value has not changed (it's not comparing the current editor value with the declaratively passed value)
The syntax switching mechanism will always switch syntax, and show the syntax error message of the selected syntax instead of preventing the user to switch syntax.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.