Skip to content

[docs/react] Fix keys and arrays example #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2021
Merged

[docs/react] Fix keys and arrays example #225

merged 1 commit into from
Feb 17, 2021

Conversation

marcagba
Copy link
Contributor

@marcagba marcagba commented Feb 16, 2021 •
edited
Loading

Fixes #224

Changes

  • Reverse parameters of the Belt.Array.mapWithIndex call
  • Convert index i to string
  • Also highlight the first line of the example (as a newcomer to rescript you're likely to ignore that you need a different function to access index within a map call).

Before

Capture d’écran 2021-02-17 à 00 28 10

After

Capture d’écran 2021-02-17 à 00 27 59

@marcagba
[docs/react] Fix keys and arrays example
a4f38b5 
* Use correctly `Belt.Array.mapWithIndex`
* Convert index to string
* Highlight first line (as a newcommer to rescript you're likely to
ignore that you need a different function to access index within a map
call).
@ryyppy ryyppy merged commit c676d83 into rescript-lang:master Feb 17, 2021
@ryyppy
Copy link
Member

ryyppy commented Feb 17, 2021

woops, thanks!

@marcagba marcagba deleted the fix/rescript-react-index-as-key-example branch February 17, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs/react] Incorrect example for item index as key
2 participants
@marcagba @ryyppy