Migrate examples to Core #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cknitt
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Thanks a lot for your work @aspeddro!
Could you fix that unction -> function thing and then we can merge?
My other two remarks seem to be regressions in the compiler output. /cc @cristianoc
| logMsg(user, datestr, "example message".toUpperCase()); | ||
| ((function (__x) { | ||
| logMsg(user, datestr, __x); | ||
| })("example message".toUpperCase())); |
There was a problem hiding this comment.
This change in the JS output seems weird.
| } | ||
|
|
||
| function dieRollMessage(name, value) { | ||
| return "Hi " + name + ", you rolled a " + value.toString(); | ||
| } | ||
|
|
||
| var message = dieRollMessage("Jeremy", Js_math.random_int(1, 6)); | ||
| var message = dieRollMessage("Jeremy", dieRoll(6)); |
There was a problem hiding this comment.
Here it seems we lost some inlining in v11 / uncurried.
Co-authored-by: Christoph Knittel <christoph@knittel.cc>
fhammerschmidt
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.