Skip to content

Playground: Don't load external @rescript/core package for ReScript 12 #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Playground: Don't load external @rescript/core package for ReScript 12 #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/common/CompilerManagerHook.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,11 +134,17 @@ let getLibrariesForVersion = (~version: Semver.t): array<string> => {
[]
}

// Since version 11, we ship the compiler-builtins as a separate file, and
// we also added @rescript/core as a pre-vendored package
// Since version 11, we ship the compiler-builtins as a separate file
if version.major >= 11 {
libraries->Array.push("@rescript/core")->ignore
libraries->Array.push("compiler-builtins")->ignore
libraries->Array.push("compiler-builtins")
}

// From version 11 to 12.0.0-alpha.3 @rescript/core is an external package
switch version {
| {major: 11}
| {major: 12, minor: 0, patch: 0, preRelease: Some(Alpha(1 | 2 | 3))} =>
libraries->Array.push("@rescript/core")
| _ => ()
}

libraries
Expand Down