Skip to content

Compatibility with ReScript 11 uncurried mode #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2023
Merged

Compatibility with ReScript 11 uncurried mode #90

merged 4 commits into from
Apr 12, 2023

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Apr 12, 2023

  • Upgrade ReScript dev dependency to 11.0.0 alpha 1 so that curried after uncurried is not fused anymore on reformat.
  • Fix signature of useSyncExternalStore bindings.
  • Fix/relax signature of useCallback bindings to work with different arities.
  • Remove type React.callback which is not needed anymore.

@cknitt cknitt requested a review from cristianoc April 12, 2023 11:37
cristianoc
cristianoc approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great thanks!
Discussed offline about whether it will work without uncurried mode.
Seems likely, but we'll find out for sure when people try.

@cknitt cknitt merged commit bb3867b into master Apr 12, 2023
@cknitt cknitt deleted the rescript-11 branch April 12, 2023 12:25
@mununki mununki mentioned this pull request May 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cknitt @cristianoc