Fix get binary dir path for monorepos #501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Or, you are free to merge this one and I deliver a test PR later. |
cristianoc
requested changes
Jul 19, 2022
cristianoc
approved these changes
Jul 19, 2022
| @@ -67,7 +67,7 @@ let send: (msg: p.Message) => void = (_) => {}; | |||
|
|
|||
| let getBinaryDirPath = (projectRootPath: p.DocumentUri) => | |||
| extensionConfiguration.binaryPath === null | |||
| ? path.join(projectRootPath, c.nodeModulesBinDir) | |||
| ? utils.findBinaryFromProjectRoot(projectRootPath) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As already discussed in Discord, I would like to extend this PR with a test runner, to free us from future regressions. Any suggestions?
cc @cknitt please check if the monorepo example is realistic enough.