Skip to content

Fix issue with ordering of module opened via -open #842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2023
Merged

Fix issue with ordering of module opened via -open #842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0e58c1
fix issue with ordering of module opened via -open in bsconfig/rescri…
zth Nov 11, 2023
7529edd
changelog
zth Nov 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@

## master

#### :bug: Bug Fix

- Fix issue `open` on submodules exposed via `-open` in bsconfig.json/rescript.json, that would cause the content of those `open` modules to not actually appear in autocomplete. https://github.com/rescript-lang/rescript-vscode/pull/842

## 1.22.0

#### :nail_care: Polish
Expand Down
2 changes: 1 addition & 1 deletion analysis/src/CompletionBackEnd.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,7 @@ let getOpens ~debug ~rawOpens ~package ~env =
if name = "PervasivesU" then "Pervasives" else name)
|> pathToString)));
let resolvedOpens =
resolveOpens ~env (List.rev (packageOpens @ rawOpens)) ~package
resolveOpens ~env (List.rev (rawOpens @ packageOpens)) ~package
in
if debug && resolvedOpens <> [] then
Printf.printf "%s\n"
Expand Down
Loading