up tests to ReScript v11 #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Jan 29, 2024
| @@ -13,7 +13,7 @@ let makePathsForModule ~projectFilesAndPaths ~dependenciesFilesAndPaths = | |||
|
|
|||
| let getReScriptVersion () = | |||
| (* TODO: Include patch stuff when needed *) | |||
| let defaultVersion = (10, 1) in | |||
| let defaultVersion = (11, 0) in | |||
There was a problem hiding this comment.
This is intentional. We can easily roll back to defaulting to 10.1 if this causes troubles (it shouldn't).
cristianoc
approved these changes
Jan 29, 2024
|
Notice CI is red. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now default to v11 in tests.