-
Notifications
You must be signed in to change notification settings - Fork 471
Closed
Labels
Description
build this code:
external createSandbox : unit => Js.t {..} = "create" [@@bs.scope "sandbox"] [@@bs.module "sinon"];
expect to genearte:
import * as Sinon from "../../node_modules/sinon";
but actual to generate:
/*
wrong:
import * as Sinon from "sinon";
*/
/* fixed */
import * as Sinon from "../../node_modules/sinon/dist/sinon.js"
refer to #1193:
how to know the path of external JS library, currently we leave it as it
Implementation details:
we might need have a global view of dependencies and pass a package map unlike current implementation which did lots of path calculation
can @bobzhang fix it?
mikaello, pocka, kmurph73 and jmezzacappa