Bsb -w seems to freeze in bs-platform@2.2.2

[alexyarovoy]

Hi,

Recently updated bs-platform to 2.2.2, and now bsb -w (as well as bsb -make-world -w) seems to stop working:

C:\Code\ReasonML\cra-test> bsb -init my-new-project -theme basic-reason
Making directory my-new-project
Symlink bs-platform in C:\Code\ReasonML\cra-test\my-new-project
C:\Code\ReasonML\cra-test\my-new-project\node_modules\bs-platform -> C:\Users\ayarovoy\AppData\Roaming\npm\node_modules\bs-platform
PS C:\Code\ReasonML\cra-test> cd .\my-new-project\
PS C:\Code\ReasonML\cra-test\my-new-project> bsb -clean-world
Cleaning... 3 files.
PS C:\Code\ReasonML\cra-test\my-new-project> bsb -make-world
ninja: Entering directory `lib\bs'
[3/3] ←[34mBuilding←[39m ←[2msrc\Demo.mlast.d←[22m
[1/1] ←[34mBuilding←[39m ←[2msrc\Demo-MyNewProject.cmj←[22m
PS C:\Code\ReasonML\cra-test\my-new-project> bsb -w
>>>> Start compiling
Rebuilding since just get started

And it stacks after that.

I’ve checked with version 2.2.0 - same result. But version 2.1.0 works like a charm.

I'm trying this on Windows 10 version 1709.

Will happily provide additional logs, if you advise me where bsb logs are located.

[bobzhang]

hi I will try to investigate it later, seems there is a couple of issues on windows recently

[bobzhang]

Seems this commit introduced the regression ddb1700#diff-7c57512e7083abca0332afab5e051638
cc @tcoopman

I will revert such commit at this time since this makes windows watch mode essentially unusable.
We can investigate it later (the worst case is that we do different code branch based on the OS version)

[bobzhang]

fixed in this release

[alexyarovoy]

@bobzhang Thank you!

[tcoopman]

@alexyarovoy, can you take a look at the comments on #2656? @OvermindDL1 said the code worked on windows, maybe it's your shell?
What shell are you using? Can you try with an other shell and see if you have the same problems on 2.2.2?

[alexyarovoy]

@tcoopman

Can you try with an other shell and see if you have the same problems on 2.2.2?

The problem is reproduced for both 2.2.2 and 2.2.0, but 2.1.0 works fine. For both shells.

answered about shells in linked issue:
"My bug report was from PowerShell, which is default in the latest Windows versions. And it is the one which is integrated in VSCode.

I've tried cmd.exe now (which was default since ever) and got the same freeze for "bsb -w"."

And just noticed, that 2.2.3 is there, and it works fine too.

[nerdyworm]

This fix breaks on OSX with elixir phoenix watchers. Process never gets the stdin close/end signal.
Uncommenting the two lines that were commented out fixes it for me.

May I suggest we add a command line argument to this feature? Webpack does it like so: https://github.com/webpack/webpack-cli/blob/7d2e8d9ed5bcdbc0e8ef1d90e273ba6f4c08f16b/bin/webpack.js#L498-L502

[tcoopman]

@nerdyworm #2656 fixes it for linux and mac, but I'm a proponent for a command/config argument as well.

@bobzhang what do you prefer?