output raw js comments

[Coobaha]

@bobzhang

I think there is no way to output raw js comments inside function body?

https://reasonml.github.io/en/try?rrjsx=true&reason=NoUhCcEMHcAICID0AqWBjA9gWywUwHYAusyi8AugNwBQtANrsQK4DOuAwhvi8QLywAzfLF4A+WAG9qsWKAgwEKdNgAOASzqRCarrBYBPIpAAesXOHAZwJMlWmwAFAEoaAX0pA

Expected behaviour:

JS output has clean comment without parentheses, works with // and /* */

[hhugo]

It seems to work

[%%raw "/* comment */"];


let useConst = fn => {
  [%raw "/* compilation syntax error */"];
  ();
};

[Coobaha]

But results in a js error

Uncaught SyntaxError: Unexpected token ')'

[bobzhang]

@Coobaha the playground version is very old, can you try it with the latest version

I can confirm it is not supported before, but should be supported since we can parse js now

[Coobaha]

@bobzhang Yes I tested locally too, it doesn't work there

[Coobaha]

@bobzhang i think it is not fixed, there is still no way to output raw comment in function body?

this is not possible:

let f x =
	 [%raw "/* eslint-disable */"];
	 ignore [%raw "/*hgosgh */  undefined"];
  x

expected:

function f(x) {
  /* eslint-disable */
  ((/*hgosgh */  undefined));
  return x;
}

Maybe bs should allow just printing comments without a raw usage?

let f x =
  (*eslint-disable*)
  x

[bobzhang]

@Coobaha may I hava a better understanding what you are trying to achieve ? Note the toplevel comments work well. The expression does not work since pure comments are not a valid expression

[Coobaha]

@bobzhang I am trying to output raw comment to disable eslint for one specific line. We are using react rules of hooks, to catch pesky closure bugs with hooks

[Coobaha]

@bobzhang bump 😇

[bobzhang]

thanks for the ping, using raw for function level comments does not seem a good abstraction.

function f(x) {
  /* eslint-disable */
  ((/*hgosgh */  undefined));
  return x;
}

If we remove the two parens, would it be a good work around

[Coobaha]

@bobzhang yes, raw comment without parens is exactly what is needed!