Wrong output for inlined object accessor

[chenglou]

Repro:

type greeting = <hi: int>;
external obj: Js.t greeting = "{hi: 1}" [@@bs.val];
external setHi : Js.t greeting => int => unit = "hi" [@@bs.set];
setHi obj 2;

Output:

{hi: 1}.hi = 2;

Needs parentheses.

[bobzhang]

This is the same as #657 , we should do more error checking (only valid qualified identifier is allowed).

I think here you want to mutate object, maybe we can provide built-in support:

type greeting = < hi : int [@bs.set] > Js.t

external mk : hi:(int [@bs.set) -> _ = "" [@@bs.obj]

Then people can just write

let f  (x : greeting Js.t) = x##hi#= 2 

Btw this is already supported in class type

class type greeting = object
  method hi : int [@bs.set]
end [@bs]

[hhugo]

object literals should be fine.
Both ({hi: 1}.hi = 2); and ({hi: 1}).hi = 2; are valid JavaScript

[bobzhang]

note we will do an error checking so that you can not write such code.

Also:

type greeting = < hi : int [@bs.set] > Js.t
class type greet = object
  method hi : int [@bs.set]
end [@bs]

is supported, I am not sure we should support bs.set on label yet.

Will make a release next week