polish the schema and fix some typos #1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OvermindDL1
reviewed
Jan 27, 2017
| @@ -15,6 +15,7 @@ if (fs.existsSync(bsconfig)) { | |||
| child_process.execFileSync(bsb_exe, delegate_args, { stdio: 'inherit' }) | |||
| } catch (e) { | |||
| console.error('Error happend when running command', bsb_exe, 'with args', delegate_args) | |||
There was a problem hiding this comment.
And happend to happened. :-)
OvermindDL1
reviewed
Jan 27, 2017
| @@ -33,6 +34,7 @@ if (fs.existsSync(bsconfig)) { | |||
| child_process.execFileSync(bsb_exe, delegate_args, { stdio: 'inherit', cwd: search_dir }) | |||
| } catch (e) { | |||
| console.error('Error happend when running command', bsb_exe, 'with args', delegate_args) | |||
There was a problem hiding this comment.
And happend to happened here too. :-)
2. error code when bsb fails
3. consistent schema changes:
a. default all public
b. sources can be either string/object or an array of string/object (which applies to subdirrs)
bobzhang
commented
Jan 30, 2017
| and parsing_sources dir_index cwd (sources : Ext_json.t ) = | ||
| match sources with | ||
| | `Arr file_groups -> | ||
| parsing_arr_sources dir_index cwd file_groups.Ext_json.content |
There was a problem hiding this comment.
we can not treat arr the same as str, otherwise it will allow arr of arr cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.