Skip to content

Revert "Change Js.toOpt to Js.toOption" #1905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2017
Merged

Revert "Change Js.toOpt to Js.toOption" #1905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jscomp/runtime/js.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ type + 'a null_undefined = 'a nullable
(** value of this type can be [undefined], [null] or ['a]
this type is the same as {!Js.Null_undefined.t}*)

external toOption : 'a nullable -> 'a option = "#null_undefined_to_opt"
external toOpt : 'a nullable -> 'a option = "#null_undefined_to_opt"
external test : 'a nullable -> bool = "#is_nil_undef"

type boolean
Expand Down Expand Up @@ -144,4 +144,4 @@ module Promise = Js_promise
module Option = Js_option
module Result = Js_result
module List = Js_list
module Vector = Js_vector
module Vector = Js_vector
4 changes: 2 additions & 2 deletions jscomp/runtime/js.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ type + 'a nullable

type + 'a null_undefined = 'a nullable

external toOption : 'a nullable -> 'a option = "#null_undefined_to_opt"
external toOpt : 'a nullable -> 'a option = "#null_undefined_to_opt"
external test : 'a nullable -> bool = "#is_nil_undef"

type boolean
Expand Down Expand Up @@ -203,4 +203,4 @@ module Result = Js_result
module List = Js_list
(** Provide utilties for list *)

module Vector = Js_vector
module Vector = Js_vector