[Super errors] Revert the colors hack #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenglou
force-pushed
the
tablez
branch
2 times, most recently
from
19b5060 to
0100198
Compare
This was referenced Aug 22, 2017
chenglou
changed the title
chenglou
force-pushed
the
tablez
branch
2 times, most recently
from
f44baee to
486ca03
Compare
Now that we're using a compiler patch for coloring, we can kill the old custom color logic I needed Took the occasion to clean up some comment and a deprecation warning
|
Good to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1919
Now that we're using a compiler patch for coloring, we can kill the old custom color logic I needed Took the occasion to clean up some comment and a deprecation warning