[Super errors] Use better unification printing #1930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobzhang
reviewed
Aug 25, 2017
| @@ -21,20 +21,20 @@ let report_error env ppf = function | |||
| "@[This variant constructor, %a, expects %i %s; here, we've %sfound %i.@]" | |||
| longident lid expected (if expected == 1 then "argument" else "arguments") (if provided < expected then "only " else "") provided | |||
| | Label_mismatch(lid, trace) -> | |||
| report_unification_error ppf env trace | |||
| super_report_unification_error ppf env trace | |||
There was a problem hiding this comment.
in the future, can you use open less
chenglou
force-pushed
the
fix-2
branch
2 times, most recently
from
9d5f3d3 to
d991e01
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1929