[Super errors] Improve constructor and record messages #2541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commonly asked questions.
|
Before (super-error formatting, but still default ocaml message): After: |
yawaramin
reviewed
Feb 28, 2018
| fprintf ppf "@[<v>\ | ||
| @{<info>The record field %a can't be found.@}@,@,\ | ||
| If it's defined in another module or file, bring it into scope by:@,\ | ||
| @[- Annotating it with said module name:@ @{<info>let baby = {myModule.age: 3}@}@]@,\ |
There was a problem hiding this comment.
Small issue, myModule needs to be MyModule.
|
Thank you! Feels like I am going to be way more productive now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commonly asked questions.