Skip to content

[Super errors] Tweak missing argument msg #2543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2018
Merged

[Super errors] Tweak missing argument msg #2543

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f03d9e
[Super errors] Tweak missing argument msg
chenglou Feb 24, 2018
94a2822
Remove unused code
chenglou Feb 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions jscomp/super_errors/super_typecore.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,12 +153,21 @@ let report_error env ppf = function
| Some (actual, expected) -> collect_missing_arguments actual expected
| None -> assert false
in
let print_arguments =
Format.pp_print_list
~pp_sep:(fun ppf _ -> fprintf ppf ",@ ")
(fun ppf (label, argtype) ->
if label = "" then fprintf ppf "@[%a@]" type_expr argtype
else fprintf ppf "@[(~%s: %a)@]" label type_expr argtype
)
in
match missing_arguments with
| Some [singleArgument] ->
fprintf ppf "@[@{<info>This call is missing a final argument@} of type@ %a@]"
print_arguments [singleArgument]
| Some arguments ->
fprintf ppf "You're missing arguments: @[%a@]" (Format.pp_print_list ~pp_sep:(fun ppf _ -> fprintf ppf ", ") (fun ppf (label, argtype) ->
if label = "" then type_expr ppf argtype
else fprintf ppf "~%s: %a" label type_expr argtype
)) arguments
fprintf ppf "@[<hv>@{<info>This call is missing final arguments@} of type:@ %a@]"
print_arguments arguments
| None ->
check_bs_arity_mismatch ppf trace;
super_report_unification_error ppf env trace
Expand Down