Skip to content

Conversation

bobzhang
Copy link
Member

No description provided.

@chenglou
Copy link
Member

bsrefmt needs to point to the new binary

@chenglou
Copy link
Member

Should we postpone this until you start your longer upgrading work? Might buy us a few months of still keeping refmt2 around? I don't mind too much either way

@bobzhang
Copy link
Member Author

what's the benefit of keeping refmt2?

@chenglou
Copy link
Member

chenglou commented Feb 28, 2018

Just in case folks are still using it but want the newest bs-platform first? Though I dunno how many people do that. Maybe it's ok to tell them to use the old bs-platform until they upgrade (I actually got PMed today from folks telling me they just upgraded).

But I think we're fine removing it too

@chenglou
Copy link
Member

chenglou commented Mar 5, 2018

https://github.com/search?p=1&q=pushed%3A%3E2018-01-01+extension%3Ajson+fork%3Afalse++%22refmt%22&type=Code&utf8=✓

No mention of "refmt": 2 as far as I can see. I think we can remove it then!

@bobzhang bobzhang merged commit 712b87d into master Mar 6, 2018
@bobzhang bobzhang deleted the remove_refmt_v2 branch March 6, 2018 06:15
@chenglou
Copy link
Member

chenglou commented Mar 6, 2018

Thanks again for hosting this for us =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants