[Super errors] Better missing param msg #2554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Continuation of rescript-lang#2548 Mini usability testing result out. Apparently the previous message was too confusing, so I'm adding back the fallback type clash msg. Additionally, I'm now using `Ctype.matches`, which considers `option('a)` and `option(string)` as equal. This, along with the original code in rescript-lang#2548, fixes reasonml-community/error-message-improvement#14 But since this produces false positives "missing parameters" msg for such code below: ```reason let a: int => float => option(int) = (a) => Some(""); ``` Where `option(int)` matches `option('a)` inferred from `Some("")`, I've also tweaked the msg to indicate that we're _guessing_ that it _might_ be because of missing parameters (but that we're not sure). The fallback type clash msg gives us leeway to guess. cc @cristianoc
|
Much better for ReasonReact. Before: After: Quality of life dramatically improved, lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2548
Mini usability testing result out. Apparently the previous message was too confusing, so I'm adding back the fallback type clash msg.
Additionally, I'm now using
Ctype.matches, which considersoption('a)andoption(string)as equal. This, along with the original code in #2548, fixes reasonml-community/error-message-improvement#14But since this produces false positives "missing parameters" msg for such code below:
Where
option(int)matchesoption('a)inferred fromSome(""), I've also tweaked the msg to indicate that we're guessing that it might be because of missing parameters (but that we're not sure). The fallback type clash msg gives us leeway to guess.cc @cristianoc