[Super errors] Make the second worst ReasonReact error a bit shorter #2612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "state escape scope" one. This one shouldn't catch any false positives, so we can safely remove the original type clash error. Also, we only detected state escaping scope, not that it's actually related to ReasonReact.componentSpec. So every state escape scope error ended up giving a ReasonReact error correction tip. This is fixed now. Sorry about that.
|
Before: After: |
chenglou
commented
Mar 13, 2018
| ] | ||
| *) | ||
| (* recursively walk the trace from right to left, calling f and checking if f matches part of the trace *) | ||
| let check_each_trace_chunk_bottom_up f = fun t -> |
There was a problem hiding this comment.
@cristianoc much clearer imo. And performant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "state escape scope" one.
This one shouldn't catch any false positives, so we can safely remove
the original type clash error.
Also, we only detected state escaping scope, not that it's actually
related to ReasonReact.componentSpec. So every state escape scope error
ended up giving a ReasonReact error correction tip. This is fixed now.
Sorry about that.