Deprecate type Js.boolean #2742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There’s one issue with deprecating types, where other occurrences of the type in the .mli also trigger the deprecation, see https://caml.inria.fr/mantis/view.php?id=7005 . In particular, the deprecation of true_ mentions boolean, and when compiled, js.mli triggers a deprecation warning. Adding `[@@ocaml.warning “-3”]` did not help. So I’ve made deprecation warnings not fatal on `jscomp/runtime`.
|
@bobzhang see comments on compiling |
|
looks great, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s one issue with deprecating types, where other occurrences of the type in the .mli also trigger the deprecation, see https://caml.inria.fr/mantis/view.php?id=7005 .
In particular, the deprecation of true_ mentions boolean, and when compiled, js.mli triggers a deprecation warning. Adding
[@@ocaml.warning “-3”]did not help. So I’ve made deprecation warnings not fatal when compilingjscomp/runtime.